Eclipse Community Forums: Virgo » Unable to load standalone war webapp using JSF 2.0

Help

Home

Home » Eclipse Projects » Virgo » Unable to load standalone war webapp using JSF 2.0

Show: Today's Messages :: Show Polls :: Message Navigator

Unable to load standalone war webapp using JSF 2.0 [message #654517]

Wed, 16 February 2011 07:53

Dan Tran

Messages: 24
Registered: February 2011

Junior Member

I am experimenting with Virgo by loading up a standalone JSF 2.0 with Primefaces 2.2.1, and Virgo complains with this message:

Cause: error Exception: org.eclipse.virgo.util.osgi.manifest.parse.BundleManifestPar seException: Error parsing bundle manifest header [javax.faces/com.sun.faces.mojarra-jsf-api] HP003E:[col 11]: Unexpected character '/' (47) HP013E:[col 12]: Expected a semicolon but found 'com' at org.eclipse.virgo.util.osgi.manifest.parse.standard.Standard HeaderParser.parseBundleSymbolicName(StandardHeaderParser.ja va:96) at org.eclipse.virgo.util.osgi.manifest.internal.StandardBundle SymbolicName.parse(StandardBundleSymbolicName.java:33) at org.eclipse.virgo.util.osgi.manifest.internal.BaseParameteri sed.resetFromParseString(BaseParameterised.java:42)

The close i can get is in sun jsf 2.0 api, its manifest file has this entry:

Bundle-SymbolicName: javax.faces/com.sun.faces.mojarra-jsf-api
Implementation-Title: Mojarra

is it a valid entry? Should Virgo care about the isolated webapp's manifest's content?

Thanks all advices

-Dan

Report message to a moderator

Re: Unable to load standalone war webapp using JSF 2.0 [message #654530 is a reply to message #654517]

Wed, 16 February 2011 08:55

Glyn Normington

Messages: 1222
Registered: July 2009

Senior Member

The OSGi spec does not permit '/' in a bundle symbolic name.

If this JAR is being installed as a bundle into Virgo, Virgo requires that its manifest is invalid. (But Violeta asks some good questions below.)

[Updated on: Wed, 16 February 2011 09:00]

Report message to a moderator

Re: Unable to load standalone war webapp using JSF 2.0 [message #654531 is a reply to message #654517]

Wed, 16 February 2011 08:56

Violeta Georgieva

Messages: 278
Registered: October 2010

Senior Member

Hi,

The Bundle-SymbolicName has to follow the syntax:

Bundle-SymbolicName ::= symbolic-name
( ';' parameter ) *

where
digit ::= [0..9]
alpha ::= [a..zA..Z]
alphanum ::= alpha | digit
token ::= ( alphanum | '_' | '-' )+
symbolic-name ::= token('.'token)*

i.e. you cannot use "/"
you can check more about this in the spec [1]

Could you please tell more about your use case i.e. do you put JSF 2.0 binaries inside the web app or you are installing the JSF 2.0 as a regular bundle?
How are you packing your web application?

Regards
Violeta

[1]http://www.osgi.org/download/r4v42/r4.core.pdf

Report message to a moderator

Re: Unable to load standalone war webapp using JSF 2.0 [message #654536 is a reply to message #654531]

Wed, 16 February 2011 09:12

Dan Tran

Messages: 24
Registered: February 2011

Junior Member

Thanks you for the reply, I switch to jsf''s myface and problem go away. Will file a bug against Sun JSF thou

Also, I have jsf api and implementation included under my WEB-INF/lib directory. So this should be a standalone webapp, no share lib/services

-D

[Updated on: Wed, 16 February 2011 09:14]

Report message to a moderator

Re: Unable to load standalone war webapp using JSF 2.0 [message #654544 is a reply to message #654531]

Wed, 16 February 2011 09:21

Dan Tran

Messages: 24
Registered: February 2011

Junior Member

I package my webapp as a war file using maven-war-plugin, both jsf api and impl are under WEB-INF/lib

I will file a bug against Sun's JSF

Thanks

-D

Report message to a moderator

Re: Unable to load standalone war webapp using JSF 2.0 [message #654547 is a reply to message #654544]

Wed, 16 February 2011 09:30

Glyn Normington

Messages: 1222
Registered: July 2009

Senior Member

It could be argued that there is also a bug in Gemini Web as it probably shouldn't be so strict on manifests of JARs in WEB-INF/lib as such JARs need not be treated as OSGi bundles.

However any JARs that have OSGi metadata really should conform to the OSGi syntax so that the JARs can easily be broken out as external dependencies of the web app, so I think we'll let the current behaviour continue.

Report message to a moderator

Re: Unable to load standalone war webapp using JSF 2.0 [message #654741 is a reply to message #654547]

Wed, 16 February 2011 22:09

Dan Tran

Messages: 24
Registered: February 2011

Junior Member

bug filed at http://java.net/jira/browse/JAVASERVERFACES-1954

Report message to a moderator

Re: Unable to load standalone war webapp using JSF 2.0 [message #654803 is a reply to message #654741]

Thu, 17 February 2011 09:04

Glyn Normington

Messages: 1222
Registered: July 2009

Senior Member

Thanks Dan.

Report message to a moderator

Re: Unable to load standalone war webapp using JSF 2.0 [message #656277 is a reply to message #654803]

Thu, 24 February 2011 20:23

Ed Burns

Messages: 4
Registered: July 2010

Junior Member

Thanks very much for taking the time to file this. It is simple to fix and I will get it fixed promptly.

Report message to a moderator

Re: Unable to load standalone war webapp using JSF 2.0 [message #656321 is a reply to message #654803]

Fri, 25 February 2011 06:03

Ed Burns

Messages: 4
Registered: July 2010

Junior Member

I have committed the fix to the sources for trunk, 2.0, and 2.1 branches.

I have also started modifying the manifests for the maven repository jars at http://download.java.net/maven/2. I started out with Mojarra 2.0.4-b09.

Please confirm that this solves your problem with that version and I'll proceed to write a script that does the rest.

Thanks,

Ed

Report message to a moderator