|
|
|
|
|
|
Re: minor annoyance with change method signature refactor [message #6787 is a reply to message #6725] |
Wed, 04 July 2007 04:10 |
Eclipse User |
|
|
|
Originally posted by: beatmik.acm.org
Konstantin Scheglov wrote:
> Konstantin Scheglov wrote:
>
>>> While I rarely use change method signature refactor and didn't want
>>> to mention this but there is nothing more annoying than Mylyn closing
>>> the Java editor I am just using. Maybe if somebody could take a look?
>>
>> Same (closing editor) happens when I rename field (may be also method).
>>
>> I've downloaded RCP package of Eclipse 3.3 mostly for Mylyn. I've
>> removed XML support from it (because I have already commercial XML
>> editor that is better). But it seems that Mylyn is still causes
>> problems as it was several months ago. :-(
>
> Same problem also happens when I use Eclipse code assist to implement
> methods in abstract class (Ctrl+Space) here "new Runnable(${cursor})".
Alex, Konstantin: If you haven't yet, could you please file a bug report
for this? I use the mechanisms that you mention very frequently and do
not see this problem, so we need to diagnose in more detail to
understand where the bad interaction is coming from.
http://www.eclipse.org/mylyn/bugs/
Mik
|
|
|
Re: minor annoyance with change method signature refactor [message #6794 is a reply to message #6751] |
Wed, 04 July 2007 04:19 |
Eclipse User |
|
|
|
Originally posted by: beatmik.acm.org
Alen Vrecko wrote:
> Sorry to be a bit blunt: That is not very user friendly way, since
> normally I would like to select lets say 4 files at once (holding ctrl)
> and add them as landmark.
>
> Surprisingly even if I select a class(not a file) I get "Not a valid
> landmark" message but if I select a method within the class then it is a
> valid landmark.
>
> IMHO: Landmarking needs some refinement. While I think it is sufficient
> if you are doing (minor) bug fixes it breaks down if for example you are
> doing some more substantial refactoring or adding some functionality to
> existing code.
>
> I know there is (Ctrl + Shift + R (Quick open)) but I would fell much
> more at ease if all the files that are revelant to me are displayed in
> the package explorer(that would still reduce quite a load of files).
As Stefan points out this is technically by design, but we have
definitely noticed it get in people's way, especially when getting
started with Mylyn and relying on manual landmarking rather than the
automatic landmarking. So we need to do something about it.
The reason that files cannot be made landmarks when the structure of a
file is understood by Mylyn (e.g. as it is for Java) is that the file is
just a container for the structured elements, and we do not allow
containers to be landmarks. One consequence of allowing them to be
landmarks is that you would see a lot more bold in your Package Explorer
than would be useful. But what we could do is something like have the
landmarking operation on the file propagate down to the first element
contained within the file (e.g. the Java class declaration). Please
post your use case on the following bug, and vote for it to help us
prioritize it:
162335: Allow "Make Landmark" to work anywhere in the file
https://bugs.eclipse.org/bugs/show_bug.cgi?id=162335
Mik
|
|
|
|
Re: minor annoyance with change method signature refactor [message #569252 is a reply to message #6710] |
Sun, 01 July 2007 06:03 |
Konstantin Scheglov Messages: 555 Registered: July 2009 |
Senior Member |
|
|
Alen Vrecko wrote:
> I find Mylyn a pleasure to work with. It is great that it only shows the
> stuff that is relevant.
>
> Cheers for the 2.0 release.
>
> But I noticed a very minor annoyance when using the change method
> signature refactor. I am using Mylyn 2.0 (same issue with 1.0) under
> Eclipse 2.2.1 and have the following problem:
>
> Let say you open X class for editing (opened Java Editor)
> Then you wish to use the change method signature refactor, go over
> method (ctrl+shift+C) the dialog pops up. And if you use ctrl+space key
> on any of the type fields. Then the Java Editor at the back would get
> closed. Surprising this always happens if I am editing an Interface and
> rarely if a Java file.
>
> While I rarely use change method signature refactor and didn't want to
> mention this but there is nothing more annoying than Mylyn closing the
> Java editor I am just using. Maybe if somebody could take a look?
Same (closing editor) happens when I rename field (may be also method).
I've downloaded RCP package of Eclipse 3.3 mostly for Mylyn. I've
removed XML support from it (because I have already commercial XML
editor that is better). But it seems that Mylyn is still causes problems
as it was several months ago. :-(
I see also that eclipse.exe hangs in memory when I close Eclipse. May
be this is problem of Mylyn, but may be not (I've placed .mylar in
remote folder).
Konstantin Scheglov,
Google, Inc.
|
|
|
Re: minor annoyance with change method signature refactor [message #569301 is a reply to message #6719] |
Sun, 01 July 2007 20:35 |
Konstantin Scheglov Messages: 555 Registered: July 2009 |
Senior Member |
|
|
Konstantin Scheglov wrote:
>> While I rarely use change method signature refactor and didn't want to
>> mention this but there is nothing more annoying than Mylyn closing the
>> Java editor I am just using. Maybe if somebody could take a look?
>
> Same (closing editor) happens when I rename field (may be also method).
>
> I've downloaded RCP package of Eclipse 3.3 mostly for Mylyn. I've
> removed XML support from it (because I have already commercial XML
> editor that is better). But it seems that Mylyn is still causes problems
> as it was several months ago. :-(
Same problem also happens when I use Eclipse code assist to implement
methods in abstract class (Ctrl+Space) here "new Runnable(${cursor})".
>
> I see also that eclipse.exe hangs in memory when I close Eclipse. May
> be this is problem of Mylyn, but may be not (I've placed .mylar in
> remote folder).
OK, this is really not problem with Mylyn.
Konstantin Scheglov,
Google, Inc.
|
|
|
|
|
|
|
|
|
Powered by
FUDForum. Page generated in 0.04490 seconds