Home » Language IDEs » Java Development Tools (JDT) » How to participate in JDT project?
| How to participate in JDT project? [message #243141] |
Mon, 23 April 2007 16:10  |
Eclipse User |
|
|
|
Originally posted by: Lars.Blumberg.commsult.de
Hello newsgroup,
I am an enthusiastic Eclipse user and in order to pass a seminar at
university I need to implement a wished feature or fix a listed bug. I
already found an interesting item in the JDT bug list and now have some
questions in order to work on this item:
1. How can I edit the JDT sources by myself? I suppose I need to edit
the appropriate files of my Eclipse distribution. For example I found my
Eclipse JDT files here:
C:\java\eclipse\plugins\org.eclipse.jdt.source_3.2.2.r322_v2 0070104-R4CR0Znkvtfjv9-
I recognized that there are a lot of "src.zip" files located. Is it
possible to edit the contained *.java files and my eclipse will run my
changes I made?
2. What is the best way to edit the JDT files using Eclipse? I suppose I
load the whole JDT project into my Eclipse. What to do else?
3. I know that, after I implemented the feature/fix, I need to publish
it on the appropriate Bugzilla entry. Is there any manual on how to
create the patch?
However, any website regarding to on how to participate in JDT/Eclipse
development is kindly welcome ;)
Thanks for any help!
Lars
Btw., I will work on an older bug list entry in order to avoid that
someone else is already working on it.
|
|
| |
| Re: How to participate in JDT project? [message #243151 is a reply to message #243141] |
Mon, 23 April 2007 17:35  |
| Eclipse User |
|
|
|
Originally posted by: wharley.bea.com
"Lars Blumberg" <Lars.Blumberg@commsult.de> wrote in message
news:f0ilu4$qs8$1@build.eclipse.org...
> Hello newsgroup,
>
> I am an enthusiastic Eclipse user and in order to pass a seminar at
> university I need to implement a wished feature or fix a listed bug. I
> already found an interesting item in the JDT bug list and now have some
> questions in order to work on this item:
>
> 1. How can I edit the JDT sources by myself?
The easiest way is to check out the source from CVS. More info on how to do
this is at http://wiki.eclipse.org/index.php/CVS_Howto. You won't be able
to actually commit your changes through CVS, because you won't have write
permissions (you'll connect with userid "anonymous"); but it's still the
best way to get the sources in editable form, and it lets you easily create
patch files.
The basic idea is: go to the CVS perspective and add a repository, using the
info at the link above; then from the list of folders in the repository
under the HEAD branch, choose the project you want (for instance,
org.eclipse.jdt.core or org.eclipse.jdt.ui) and select "Check Out".
> 2. What is the best way to edit the JDT files using Eclipse? I suppose I
> load the whole JDT project into my Eclipse. What to do else?
When you've checked out the project from CVS, as described above, it will
show up in your workspace and you can edit to your heart's (or advisor's)
content.
You may also want to check out the corresponding test projects - for
instance, org.eclipse.jdt.core.tests.*. That way you can run the JUnit
tests to make sure your change didn't break anything, and you can add tests
for the new functionality you write.
> 3. I know that, after I implemented the feature/fix, I need to publish it
> on the appropriate Bugzilla entry. Is there any manual on how to create
> the patch?
As you change files in a CVS project, you'll notice that they get marked
with a ">" before them in the Navigator; this tells you that the file is
different from what's in the repository. When you are ready, just
right-click the project (or projects) that you've modified, and select
Team -> Create Patch. Give the patch file a name (like
"bug12345-patch1.txt") and you can then attach the file to the Bugzilla bug
entry.
> Btw., I will work on an older bug list entry in order to avoid that
> someone else is already working on it.
If a bug isn't in "ASSIGNED" state, then probably no one is working on it.
The problem with choosing an older entry is that if it is an old unfixed
bug, it is probably unfixed either because no one cares a lot about it, or
because fixing it will be challenging or risky. There are, of course,
exceptions.
Hope that helps,
-Walter Harley
JDT APT team
|
|
|
| Re: How to participate in JDT project? [message #243165 is a reply to message #243151] |
Tue, 24 April 2007 12:34 |
| Eclipse User |
|
|
|
Originally posted by: Lars.Blumberg.commsult.de
Hello Walter,
thank you a lot for your detailed instructions. They will will help me a
lot to participate in the project. I will have a look again at the bug
list, maybe I find another, more important item to work on. Creating a
patch sounds easy but I know that I need to carefully follow the coding
guidelines in order to have the patch being accepted.
With best regards
Lars Blumberg
Walter Harley schrieb:
> "Lars Blumberg" <Lars.Blumberg@commsult.de> wrote in message
> news:f0ilu4$qs8$1@build.eclipse.org...
>> Hello newsgroup,
>>
>> I am an enthusiastic Eclipse user and in order to pass a seminar at
>> university I need to implement a wished feature or fix a listed bug. I
>> already found an interesting item in the JDT bug list and now have some
>> questions in order to work on this item:
>>
>> 1. How can I edit the JDT sources by myself?
>
> The easiest way is to check out the source from CVS. More info on how to do
> this is at http://wiki.eclipse.org/index.php/CVS_Howto. You won't be able
> to actually commit your changes through CVS, because you won't have write
> permissions (you'll connect with userid "anonymous"); but it's still the
> best way to get the sources in editable form, and it lets you easily create
> patch files.
>
> The basic idea is: go to the CVS perspective and add a repository, using the
> info at the link above; then from the list of folders in the repository
> under the HEAD branch, choose the project you want (for instance,
> org.eclipse.jdt.core or org.eclipse.jdt.ui) and select "Check Out".
>
>
>> 2. What is the best way to edit the JDT files using Eclipse? I suppose I
>> load the whole JDT project into my Eclipse. What to do else?
>
> When you've checked out the project from CVS, as described above, it will
> show up in your workspace and you can edit to your heart's (or advisor's)
> content.
>
> You may also want to check out the corresponding test projects - for
> instance, org.eclipse.jdt.core.tests.*. That way you can run the JUnit
> tests to make sure your change didn't break anything, and you can add tests
> for the new functionality you write.
>
>
>> 3. I know that, after I implemented the feature/fix, I need to publish it
>> on the appropriate Bugzilla entry. Is there any manual on how to create
>> the patch?
>
> As you change files in a CVS project, you'll notice that they get marked
> with a ">" before them in the Navigator; this tells you that the file is
> different from what's in the repository. When you are ready, just
> right-click the project (or projects) that you've modified, and select
> Team -> Create Patch. Give the patch file a name (like
> "bug12345-patch1.txt") and you can then attach the file to the Bugzilla bug
> entry.
>
>
>> Btw., I will work on an older bug list entry in order to avoid that
>> someone else is already working on it.
>
> If a bug isn't in "ASSIGNED" state, then probably no one is working on it.
> The problem with choosing an older entry is that if it is an old unfixed
> bug, it is probably unfixed either because no one cares a lot about it, or
> because fixing it will be challenging or risky. There are, of course,
> exceptions.
>
>
> Hope that helps,
> -Walter Harley
> JDT APT team
>
>
|
|
|
| Re: How to participate in JDT project? [message #243170 is a reply to message #243146] |
Tue, 24 April 2007 12:35 |
| Eclipse User |
|
|
|
Originally posted by: Lars.Blumberg.commsult.de
Hello Darin,
your URLs are very helpful and they give me a good starting point for my
work. Thank you a lot!
With best regards
Lars Blumberg
Darin Swanson schrieb:
> I would suggest that your first step would be to get in touch with the JDT
> team either via there development list or within the bug report to indicate
> your interest.
> I would also suggest bug fix over feature. Look for bugs with the helpwanted
> tag.
> Also read here:
> http://www.eclipse.org/jdt/ui/dev.php
>
> The Debug team has some instructions for how to setup for their work
> environment. You should be able to adapt these to figure out how to self
> host on JDT
> http://www.eclipse.org/eclipse/debug/contribute.php
>
> Good luck
> Darins
>
> "Lars Blumberg" <Lars.Blumberg@commsult.de> wrote in message
> news:f0ilu4$qs8$1@build.eclipse.org...
>> Hello newsgroup,
>>
>> I am an enthusiastic Eclipse user and in order to pass a seminar at
>> university I need to implement a wished feature or fix a listed bug. I
>> already found an interesting item in the JDT bug list and now have some
>> questions in order to work on this item:
>>
>> 1. How can I edit the JDT sources by myself? I suppose I need to edit the
>> appropriate files of my Eclipse distribution. For example I found my
>> Eclipse JDT files here:
>>
>> C:\java\eclipse\plugins\org.eclipse.jdt.source_3.2.2.r322_v2 0070104-R4CR0Znkvtfjv9-
>>
>> I recognized that there are a lot of "src.zip" files located. Is it
>> possible to edit the contained *.java files and my eclipse will run my
>> changes I made?
>>
>> 2. What is the best way to edit the JDT files using Eclipse? I suppose I
>> load the whole JDT project into my Eclipse. What to do else?
>>
>> 3. I know that, after I implemented the feature/fix, I need to publish it
>> on the appropriate Bugzilla entry. Is there any manual on how to create
>> the patch?
>>
>> However, any website regarding to on how to participate in JDT/Eclipse
>> development is kindly welcome ;)
>>
>> Thanks for any help!
>>
>> Lars
>>
>>
>> Btw., I will work on an older bug list entry in order to avoid that
>> someone else is already working on it.
>
>
|
|
|
| Re: How to participate in JDT project? [message #243181 is a reply to message #243165] |
Tue, 24 April 2007 17:52 |
| Eclipse User |
|
|
|
Originally posted by: wharley.bea.com
"Lars Blumberg" <Lars.Blumberg@commsult.de> wrote in message
news:f0ktkq$f4k$1@build.eclipse.org...
> Hello Walter,
>
> thank you a lot for your detailed instructions. They will will help me a
> lot to participate in the project. I will have a look again at the bug
> list, maybe I find another, more important item to work on. Creating a
> patch sounds easy but I know that I need to carefully follow the coding
> guidelines in order to have the patch being accepted.
It is certainly helpful to try to fit in with whatever code you are fixing;
it helps keep the code readable by others, instead of becoming a patchwork
of different styles. You will find that different parts of the JDT code
base have different styles, but whatever part you're working in, try to
stick with that style. If nothing else, matching style indicates that
you've read enough of the existing code to be able to make correct
modifications, and it helps the person who reviews your patch.
More important than style, though, is that your changes must be correct and
useful. We sometimes see patches from people who change the functionality
to support a particular use case they are interested in, but in doing so
they unwittingly break other use cases or impair performance. Every line of
code has a cost in memory space, speed, bugs, and maintenance effort; it has
to earn its keep by providing enough benefit to enough people. That's
really the key to getting a patch accepted.
Thanks!
-Walter
|
|
|
| Re: How to participate in JDT project? [message #243184 is a reply to message #243181] |
Wed, 25 April 2007 08:31 |
| Eclipse User |
|
|
|
Originally posted by: Lars.Blumberg.commsult.de
Walter Harley schrieb:
> "Lars Blumberg" <Lars.Blumberg@commsult.de> wrote in message
> news:f0ktkq$f4k$1@build.eclipse.org...
>> Hello Walter,
>>
>> thank you a lot for your detailed instructions. They will will help me a
>> lot to participate in the project. I will have a look again at the bug
>> list, maybe I find another, more important item to work on. Creating a
>> patch sounds easy but I know that I need to carefully follow the coding
>> guidelines in order to have the patch being accepted.
>
>
> It is certainly helpful to try to fit in with whatever code you are fixing;
> it helps keep the code readable by others, instead of becoming a patchwork
> of different styles. You will find that different parts of the JDT code
> base have different styles, but whatever part you're working in, try to
> stick with that style. If nothing else, matching style indicates that
> you've read enough of the existing code to be able to make correct
> modifications, and it helps the person who reviews your patch.
>
> More important than style, though, is that your changes must be correct and
> useful. We sometimes see patches from people who change the functionality
> to support a particular use case they are interested in, but in doing so
> they unwittingly break other use cases or impair performance. Every line of
> code has a cost in memory space, speed, bugs, and maintenance effort; it has
> to earn its keep by providing enough benefit to enough people. That's
> really the key to getting a patch accepted.
>
> Thanks!
> -Walter
>
>
So far I already participated in some software projects, dived in its
code and I know what it means to adopt the existing coding style and I
know the benefits of following individual coding guidelines of each
individual project. That is why I fully understand and agree to your
argumentation and try my best to make my patch easy to read and being
accepted by the decision-makers.
Thanks again,
Lars
|
|
| | |
| Re: Which CVS version to use for creating a patch? [message #243651 is a reply to message #243646] |
Thu, 10 May 2007 20:49 |
| Eclipse User |
|
|
|
Originally posted by: wharley.bea.com
"Lars Blumberg" <Lars.Blumberg@student.hpi.uni-potsdam.de> wrote in message
news:f1vph5$hpa$1@build.eclipse.org...
> I made a mistiake: I do not mean the last stable, I want to now whether to
> work with the latest release or with latest CVS version of Eclipse. I am
> sorry.
Typically for doing bug fixing or new feature development, you should use
the latest milestone release as your host platform, and then in your
workspace you should have the latest CVS version ("HEAD") of whatever
plug-ins you're working on.
For example, I occasionally suggest patches to org.eclipse.jdt.core; so, I
am using Eclipse 3.3M7 as my development platform, and I have a workspace in
which I have checked out the org.eclipse.jdt.core CVS project.
|
|
|
| I successfully supplied my first Eclipse patch [message #244133 is a reply to message #243651] |
Wed, 30 May 2007 21:05 |
 Lars Blumberg
Messages: 3
Registered: July 2009 |
Junior Member |
|
|
Walter Harley wrote:
> "Lars Blumberg" <Lars.Blumberg@student.hpi.uni-potsdam.de> wrote in message
> news:f1vph5$hpa$1@build.eclipse.org...
>> I made a mistiake: I do not mean the last stable, I want to now whether to
>> work with the latest release or with latest CVS version of Eclipse. I am
>> sorry.
>
> Typically for doing bug fixing or new feature development, you should use
> the latest milestone release as your host platform, and then in your
> workspace you should have the latest CVS version ("HEAD") of whatever
> plug-ins you're working on.
>
> For example, I occasionally suggest patches to org.eclipse.jdt.core; so, I
> am using Eclipse 3.3M7 as my development platform, and I have a workspace in
> which I have checked out the org.eclipse.jdt.core CVS project.
>
>
Yeah, I supplied my first patch and now I am curious what happens next
and which answers will be posted to the bug item. But I suppose that
this patch will not be included soon, because the latest Eclipse version
is in Release Candidate state (great improvements have been developed!).
If I look back Eclipse makes it very, very easy enhancing it. Just get
the latest desired packages via CVS, edit them and debug it. Then choose
"create patch" and all is done. Wow, did not know that Eclipse provides
so much helping tools making development such easy.
With best regards
Lars
|
|
|
| Re: I successfully supplied my first Eclipse patch [message #244159 is a reply to message #244133] |
Thu, 31 May 2007 19:36 |
| Eclipse User |
|
|
|
Originally posted by: wharley.bea.com
"Lars Blumberg" <Lars.Blumberg@student.hpi.uni-potsdam.de> wrote in message
news:f3kov8$4cm$1@build.eclipse.org...
>
> Yeah, I supplied my first patch and now I am curious what happens next and
> which answers will be posted to the bug item. But I suppose that this
> patch will not be included soon, because the latest Eclipse version is in
> Release Candidate state (great improvements have been developed!).
Correct, but as soon as we ship 3.3 we will start work on 3.3.1, so you
could get into that. What's the bug number?
> If I look back Eclipse makes it very, very easy enhancing it. Just get the
> latest desired packages via CVS, edit them and debug it. Then choose
> "create patch" and all is done. Wow, did not know that Eclipse provides so
> much helping tools making development such easy.
To a fault, perhaps :-) Eclipse is sometimes accused of being optimized for
enhancing Eclipse, rather than on other types of coding.
|
|
|
| Re: I successfully supplied my first Eclipse patch [message #244174 is a reply to message #244159] |
Fri, 01 June 2007 08:22 |
Dani Megert
Messages: 3802
Registered: July 2009 |
Senior Member |
|
|
Walter Harley wrote:
>"Lars Blumberg" <Lars.Blumberg@student.hpi.uni-potsdam.de> wrote in message
>news:f3kov8$4cm$1@build.eclipse.org...
>
>
>>Yeah, I supplied my first patch and now I am curious what happens next and
>>which answers will be posted to the bug item. But I suppose that this
>>patch will not be included soon, because the latest Eclipse version is in
>>Release Candidate state (great improvements have been developed!).
>>
>>
>
>Correct, but as soon as we ship 3.3 we will start work on 3.3.1, so you
>could get into that.
>
Not really, as 3.3.1 will be a maintenance release. But 3.4 will get
started too and that's where it
will most likely end up if accepted.
Dani
> What's the bug number?
>
>
>
>
>>If I look back Eclipse makes it very, very easy enhancing it. Just get the
>>latest desired packages via CVS, edit them and debug it. Then choose
>>"create patch" and all is done. Wow, did not know that Eclipse provides so
>>much helping tools making development such easy.
>>
>>
>
>To a fault, perhaps :-) Eclipse is sometimes accused of being optimized for
>enhancing Eclipse, rather than on other types of coding.
>
>
>
>
|
|
|
Goto Forum:
Current Time: Tue Jul 16 06:50:13 GMT 2024
Powered by FUDForum. Page generated in 0.04720 seconds |
] 
Search
Help
Register
Login
Home
