Eclipse Community Forums: GMF (Graphical Modeling Framework) » implementing ILayoutNodeProvider

Help

Home

Home » Modeling » GMF (Graphical Modeling Framework) » implementing ILayoutNodeProvider - best practices

Show: Today's Messages :: Show Polls :: Message Navigator

implementing ILayoutNodeProvider - best practices [message #200201]

Mon, 04 August 2008 16:47

Seweryn Niemiec

Messages: 80
Registered: July 2009

Member

Hi

I'm implementing my custom layout provider and I have the dilemma: to
override AbstractLayoutNodeProvider or AbstractLayoutEditPartProvider?

AbstractLayoutEditPartProvider encourage me to create commands for every
node move, which consumes much more computer resources. What is it for?
Does it have any benefits over simple implementation of
ILayoutNodeProvider#layoutLayoutNodes, which creates Runnable with
algorithm implementation and returns it?

Greetings,
Seweryn Niemiec

Report message to a moderator

Re: implementing ILayoutNodeProvider - best practices [message #200216 is a reply to message #200201]

Mon, 04 August 2008 17:40

Seweryn Niemiec

Messages: 80
Registered: July 2009

Member

Seweryn Niemiec wrote:
> AbstractLayoutEditPartProvider encourage me to create commands for every
> node move, which consumes much more computer resources. What is it for?

After some debugging I have found that using
AbstractLayoutEditPartProvider is actually a very BAD practice because
in this case computer will perform layout computations and
requests+commands creations two times per every selection of node
supported by my layout provider. This is caused by the fact that actual
computations are performed by the code which prepares layouting Runnable
instead of inside of Runnable's run() method.

If I'm not wrong, probably there should be filled a bug describing this
issue.

Greetings,
Seweryn Niemiec

Report message to a moderator