Eclipse Community Forums: JFace » CheckBoxTreeViewer and CellEditor combination is buggy

Help

Home

Home » Eclipse Projects » JFace » CheckBoxTreeViewer and CellEditor combination is buggy

Show: Today's Messages :: Show Polls :: Message Navigator

CheckBoxTreeViewer and CellEditor combination is buggy [message #678]

Wed, 06 May 2009 10:05

philipp huebner

Messages: 67
Registered: July 2009

Member

Hello together,

I'm posting this here because I can't find a JFace related newsgroup.
Today I've finished my work with a JFace TreeViewer with Check Boxes and a
Cell Editor for in-place editing and discoverd some issues. I'm on winxp
32.

no Double Click:
It uses a textfiled, so when you single click on a tree item, the
textfield will get focus and the tree can't react on double click's any
more! The windows behaviour is to wait 0,5 sec before editing, cause it
waits for double click.

text field stays:
when you delete the tree item just editing, the text field will stay in
the tree

text field reacts on checkbox click:
if you click a checkbox of a selected treeItem, thze edit mode will
activated, because a checkbox click fires a mouse-up event...

Report message to a moderator

Re: CheckBoxTreeViewer and CellEditor combination is buggy [message #1454 is a reply to message #678]

Wed, 06 May 2009 10:23

Thomas Schindl

Messages: 6651
Registered: July 2009

Senior Member

philipp huebner schrieb:
> Hello together,
>
> I'm posting this here because I can't find a JFace related newsgroup.
> Today I've finished my work with a JFace TreeViewer with Check Boxes and
> a Cell Editor for in-place editing and discoverd some issues. I'm on
> winxp 32.
>
> no Double Click:
> It uses a textfiled, so when you single click on a tree item, the
> textfield will get focus and the tree can't react on double click's any
> more! The windows behaviour is to wait 0,5 sec before editing, cause it
> waits for double click.

so what would you expect to happen on double click. Please note that our
Editing code has special handling when the editor is enabled and a
double click is happening in time of the defined double click => we are
then firing a double click which you get by attaching a
IDoubleClickListener on the viewer. If you want to mimic the Windows
behaviour I'd say you could customize
ColumnViewerEditorActivationStrategy to return false on single click and
then wait 0,5 sec and active the editor using viewer.editElement().

>
> text field stays:
> when you delete the tree item just editing, the text field will stay in
> the tree
>

Who is deleting/disposing the item? Looking at our code we are attaching
a dipose-listener on the current item which cancels the editing

> text field reacts on checkbox click:
> if you click a checkbox of a selected treeItem, thze edit mode will
> activated, because a checkbox click fires a mouse-up event...
>

I see. We need to see if the mouse event informs us about this being a
check-toggeling but we also pass on all informations to you in our
ColumnViewerEditorActivationStrategy. If no such information is passed
we might have to check the widget bounds to find out the click happened
on the checkbox and not at the widget-content.

Tom

Report message to a moderator

Re: CheckBoxTreeViewer and CellEditor combination is buggy [message #1463 is a reply to message #1454]

Wed, 06 May 2009 12:18

philipp huebner

Messages: 67
Registered: July 2009

Member

so what would you expect to happen on double click. Please note that our
Editing code has special handling when the editor is enabled and a
double click is happening in time of the defined double click => we are
then firing a double click which you get by attaching a
IDoubleClickListener on the viewer. If you want to mimic the Windows
behaviour I'd say you could customize
ColumnViewerEditorActivationStrategy to return false on single click and
then wait 0,5 sec and active the editor using viewer.editElement().

hmm. In my code i loose double clicks. I'll look at it deeper...
I started a thread waiting 0,5 sec.

Who is deleting/disposing the item? Looking at our code we are attaching
a dipose-listener on the current item which cancels the editing

I did sth similar.

I see. We need to see if the mouse event informs us about this being a
check-toggeling but we also pass on all informations to you in our
ColumnViewerEditorActivationStrategy. If no such information is passed
we might have to check the widget bounds to find out the click happened
on the checkbox and not at the widget-content.

i check the widget bounds.

Report message to a moderator

Re: CheckBoxTreeViewer and CellEditor combination is buggy [message #1506 is a reply to message #1463]

Wed, 06 May 2009 14:24

Boris Bokowski

Messages: 272
Registered: July 2009

Senior Member

Philipp,

It might be best to attach a snippet to make sure we are talking about the
same thing.

Boris

"philipp huebner" <philipp.huebner@teraport.de> wrote in message
news:1504da33cfde960ed93a15e823b53ad5$1@www.eclipse.org...
>
>
> so what would you expect to happen on double click. Please note that our
> Editing code has special handling when the editor is enabled and a
> double click is happening in time of the defined double click => we are
> then firing a double click which you get by attaching a
> IDoubleClickListener on the viewer. If you want to mimic the Windows
> behaviour I'd say you could customize
> ColumnViewerEditorActivationStrategy to return false on single click and
> then wait 0,5 sec and active the editor using viewer.editElement().
>
> hmm. In my code i loose double clicks. I'll look at it deeper...
> I started a thread waiting 0,5 sec.
>
> Who is deleting/disposing the item? Looking at our code we are attaching
> a dipose-listener on the current item which cancels the editing
>
> I did sth similar.
>
> I see. We need to see if the mouse event informs us about this being a
> check-toggeling but we also pass on all informations to you in our
> ColumnViewerEditorActivationStrategy. If no such information is passed
> we might have to check the widget bounds to find out the click happened
> on the checkbox and not at the widget-content.
>
> i check the widget bounds.
>

Report message to a moderator

Re: CheckBoxTreeViewer and CellEditor combination is buggy [message #1646 is a reply to message #1506]

Thu, 07 May 2009 11:26

philipp huebner

Messages: 67
Registered: July 2009

Member

I create it like this:

PatternFilter patternFilter = new PatternFilter();
filteredTree = new CustomFilteredTree(getContainer(), SWT.MULTI
| SWT.H_SCROLL | SWT.V_SCROLL | SWT.BORDER | SWT.CHECK,
patternFilter);

selectionViewer = (CustomContainerCheckedTreeViewer) filteredTree
.getViewer();
selectionViewer.setAutoExpandLevel(TreeViewer.ALL_LEVELS);
setCurrentViewer(selectionViewer);

cp = new AdapterFactoryContentProvider(adapterFactory);
selectionViewer.setContentProvider(cp);

// Cell Editor can be activated here
treeEditor = new CommandBasedAdapterFactoryTreeEditor(selectionViewer
.getTree(), adapterFactory, editingDomain);

Report message to a moderator

Re: CheckBoxTreeViewer and CellEditor combination is buggy [message #1669 is a reply to message #1646]

Thu, 07 May 2009 12:38

philipp huebner

Messages: 67
Registered: July 2009

Member

dispose: which code implements a dispose listener? not mine. I use
standandrd api which ends in a dangling textfield?!?

Report message to a moderator

Re: CheckBoxTreeViewer and CellEditor combination is buggy [message #1680 is a reply to message #1669]

Thu, 07 May 2009 12:46

Thomas Schindl

Messages: 6651
Registered: July 2009

Senior Member

Hi,

ColumnViewerEditor adds the listener on the item. What version of JFace
are you using.

The code you showed us is not enough what we need is a real snippet we
can use to see the problems in action.

Use one of our existing ones [1] and modify it so that we can see the
problems you are having at our local workstations.

Tom

[1]http://wiki.eclipse.org/JFaceSnippets

philipp huebner schrieb:
> dispose: which code implements a dispose listener? not mine. I use
> standandrd api which ends in a dangling textfield?!?
>

Report message to a moderator

Previous Topic:	JFace Data Binding/Getting started
Next Topic:	System.out.println into a TableViewer

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

]

Current Time: Fri Dec 27 01:42:13 GMT 2024

.:: Contact :: Home ::.

Breadcrumbs

Sign up to our Newsletter