Eclipse Community Forums: GEF » BendpointEditPolicy bug

Home » Eclipse Projects » GEF » BendpointEditPolicy bug

BendpointEditPolicy bug [message #54230]

Mon, 13 January 2003 09:13

Eclipse User

This is a multi-part message in MIME format.

------=_NextPart_000_006D_01C2BB16.66082680
Content-Type: text/plain;
charset="iso-8859-2"
Content-Transfer-Encoding: quoted-printable

I am not sure, but I think there is a bug in BendpointEditPolicy class. =
When I create BendpointRequest with request type set to =
REQ_DELETE_BENDPOINT than no command returned on getCommand(request) =
call. Method getDeleteBendpointCommand(request:BendpointRequest):Command =
is not called.
I think that method getCommand(request:Request) should contain folowing =
code (or similar)

public Command getCommand(Request request) {
if (REQ_MOVE_BENDPOINT.equals(request.getType())) {
if (isDeleting) {
return getDeleteBendpointCommand((BendpointRequest) =
request);
}
return getMoveBendpointCommand((BendpointRequest)request);
}
if (REQ_CREATE_BENDPOINT.equals(request.getType())) {
return getCreateBendpointCommand((BendpointRequest)request);
}
if(request.getType().equals(RequestConstants.REQ_DELETE_BEND POINT)) =
{
return this.getDeleteBendpointCommand((BendpointRequest) =
request);
}
return null;
}

[Q] Do you thing it is correct to leave REQ_MOVE_BENDPOINT as type of =
request in call getDeleteBendpointCommand method when isDeleted is true? =
Isn't it better to do something like:
public Command getCommand(Request request) {
if (REQ_MOVE_BENDPOINT.equals(request.getType())) {
if (isDeleting) {
request.setType(RequestConstants.REQ_DELETE_BENDPOINT);
return getDeleteBendpointCommand((BendpointRequest) =
request);
}
return getMoveBendpointCommand((BendpointRequest)request);
}
if (REQ_CREATE_BENDPOINT.equals(request.getType())) {
return getCreateBendpointCommand((BendpointRequest)request);
}
if(RequestConstants.REQ_DELETE_BENDPOINT.equals(request.getT ype())) =
{
return this.getDeleteBendpointCommand((BendpointRequest) =
request);
}
return null;
}

Regards,
Roman Bosak

------=_NextPart_000_006D_01C2BB16.66082680
Content-Type: text/html;
charset="iso-8859-2"
Content-Transfer-Encoding: quoted-printable

<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN">
<HTML><HEAD>
<META http-equiv=3DContent-Type content=3D"text/html; =
charset=3Diso-8859-2">
<META content=3D"MSHTML 6.00.2800.1126" name=3DGENERATOR>
<STYLE></STYLE>
</HEAD>
<BODY>
<DIV>I am not sure, but I think there is a =
bug in=20
BendpointEditPolicy =
class. When=20
I create BendpointRequest with=20
request type set to <FONT=20
face=3D"Courier New">REQ_DELETE_BENDPOINT than no =
command returned=20
on getCommand(request)=20
call. Method <FONT=20
face=3D"Courier =
New">getDeleteBendpointCommand(request:BendpointRequest):Command <=
/STRONG>=20
is not called.</DIV>
<DIV>I think that method <FONT=20
face=3D"Courier New">getCommand(request:Request) =
should=20
contain folowing code (or similar)</DIV>
<DIV><FONT=20
face=3D"Courier New" size=3D2> </DIV>
<DIV><FONT=20
face=3D"Courier New" size=3D2>public Command=20
getCommand(Request request) {     <FONT=20
face=3D"Courier New" size=3D2>if=20
(REQ_MOVE_BENDPOINT.equals(request.getType())) {    =20
    if =
(isDeleting)=20
{            &nbs=
p;=20
return=20
getDeleteBendpointCommand((BendpointRequest) =
request);    =20
    }         <FONT=20
face=3D"Courier New" size=3D2>return=20
getMoveBendpointCommand((BendpointRequest)request); <FONT=20
face=3D"Courier New" size=3D2>    }     =

if=20
(REQ_CREATE_BENDPOINT.equals(request.getType())) {     =

    return=20
getCreateBendpointCommand((BendpointRequest)request);   &nbs=
p;=20
}     if(request.getType().equals(RequestConstants.REQ_DELETE_=
BENDPOINT))=20
{         return=20
this.getDeleteBendpointCommand((BendpointRequest)=20
request);     }<FONT=20
face=3D"Courier New">     <FONT=20
face=3D"Courier New">return null; <FONT=20
face=3D"Courier New" size=3D2>}</DIV>
<DIV> </DIV>
<DIV>[Q] Do you thing it is correct to leave =
<FONT=20
face=3D"Courier New">REQ_MOVE_BENDPOINT as type =
of=20
request in call <FONT=20
face=3D"Courier New">getDeleteBendpointCommand =
method when=20
isDeleted is true? =
Isn't it=20
better to do something like:</DIV>
<DIV>
public=20
Command getCommand(Request request) {     if=20
(REQ_MOVE_BENDPOINT.equals(request.getType())) {    =20
    if =
(isDeleting)=20
{             =20
request.setType(RequestConstants.REQ_DELETE_BENDPOINT); <=
/FONT><FONT=20
size=3D+0>           &n=
bsp; =20
return=20
getDeleteBendpointCommand((BendpointRequest) =
request);    =20
    <FONT=20
face=3D"Courier New" size=3D2>}         <FONT=20
face=3D"Courier New" size=3D2>return=20
getMoveBendpointCommand((BendpointRequest)request); <FONT=20
face=3D"Courier New" size=3D2>    }     =

if=20
(REQ_CREATE_BENDPOINT.equals(request.getType())) {     =

    return=20
getCreateBendpointCommand((BendpointRequest)request);   &nbs=
p;=20
}     if(RequestConstants.REQ_DELETE_BENDPOINT.equals(request.getT ype(=
)))=20
{           </FONT=
><FONT=20
face=3D"Courier New" size=3D2><FONT=20
face=3D"Courier New" size=3D2>return=20
this.getDeleteBendpointCommand((BendpointRequest)=20
request);     }<FONT=20
face=3D"Courier New">     <FONT=20
face=3D"Courier New">return null; }</DIV>
<DIV> </DIV>
<DIV>Regards,</DIV>
<DIV>Roman Bosak</DIV>
<DIV> </DIV></BODY></HTML>

------=_NextPart_000_006D_01C2BB16.66082680--

Re: BendpointEditPolicy bug [message #58822 is a reply to message #54230]

Tue, 28 January 2003 15:30

Eclipse User

Originally posted by: none.us.ibm.com

This is a multi-part message in MIME format.

------=_NextPart_000_008A_01C2C6E2.3636BA20
Content-Type: text/plain;
charset="iso-8859-2"
Content-Transfer-Encoding: quoted-printable

Some routers will use an orthoganal (manhattan) routing method, such as =
Rational Rose. For these routers, it is not always a straight line that =
indicates that the bendpoint should be deleted. If you have

O--- a
|=20
|
x---|
|
O

where "x" indicates a bendpoint, then moving "x" to point "a" indicates =
that the bendpoint should be deleted. This implies that a general =
bendpoint drag tracker cannot know when to sent a DeleteRequest.

ConnectionBendpointTracker is independant of the router being used, so =
it consider *all* operations to be REQ_MOVE_BENDPOINT. Delete is =
*interpreted* by the BendpointEditPolicy, never sent by the drag =
tracker. REQ_DELETE_BENDPOINT is never used. It should probably be =
deleted.
"Roman Bos=E1k" <bosakr@dev.disnet.cz> wrote in message =
news:avugni$crl$1@rogue.oti.com...
I am not sure, but I think there is a bug in BendpointEditPolicy =
class. When I create BendpointRequest with request type set to =
REQ_DELETE_BENDPOINT than no command returned on getCommand(request) =
call. Method getDeleteBendpointCommand(request:BendpointRequest):Command =
is not called.
I think that method getCommand(request:Request) should contain =
folowing code (or similar)

public Command getCommand(Request request) {
if (REQ_MOVE_BENDPOINT.equals(request.getType())) {
if (isDeleting) {
return getDeleteBendpointCommand((BendpointRequest) =
request);
}
return getMoveBendpointCommand((BendpointRequest)request);
}
if (REQ_CREATE_BENDPOINT.equals(request.getType())) {
return getCreateBendpointCommand((BendpointRequest)request);
}
=
if(request.getType().equals(RequestConstants.REQ_DELETE_BEND POINT)) {
return this.getDeleteBendpointCommand((BendpointRequest) =
request);
}
return null;
}

[Q] Do you thing it is correct to leave REQ_MOVE_BENDPOINT as type of =
request in call getDeleteBendpointCommand method when isDeleted is true? =
Isn't it better to do something like:
public Command getCommand(Request request) {
if (REQ_MOVE_BENDPOINT.equals(request.getType())) {
if (isDeleting) {
request.setType(RequestConstants.REQ_DELETE_BENDPOINT);
return getDeleteBendpointCommand((BendpointRequest) =
request);
}
return getMoveBendpointCommand((BendpointRequest)request);
}
if (REQ_CREATE_BENDPOINT.equals(request.getType())) {
return getCreateBendpointCommand((BendpointRequest)request);
}
=
if(RequestConstants.REQ_DELETE_BENDPOINT.equals(request.getT ype())) {
return this.getDeleteBendpointCommand((BendpointRequest) =
request);
}
return null;
}

Regards,
Roman Bosak

------=_NextPart_000_008A_01C2C6E2.3636BA20
Content-Type: text/html;
charset="iso-8859-2"
Content-Transfer-Encoding: quoted-printable

<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN">
<HTML><HEAD>
<META http-equiv=3DContent-Type content=3D"text/html; =
charset=3Diso-8859-2">
<META content=3D"MSHTML 6.00.2600.0" name=3DGENERATOR>
<STYLE></STYLE>
</HEAD>
<BODY bgColor=3D#ffffff>
<DIV>Some routers will use an orthoganal =
(manhattan)=20
routing method, such as Rational Rose.  For =
these routers, it is=20
not always a straight line that indicates that the bendpoint should be =
deleted.=20
If you have</DIV>
<DIV> </DIV>
<DIV>O---   a</DIV>
<DIV>   | </DIV>
<DIV>   |</DIV>
<DIV>   x---|</DIV>
<DIV>        =20
|</DIV>
<DIV>        =20
O</DIV>
<DIV> </DIV>
<DIV>where "x" indicates a bendpoint, then =
moving "x" to=20
point "a" indicates that the bendpoint should be deleted. This implies =
that a=20
general bendpoint drag tracker cannot know when to sent a=20
DeleteRequest.</DIV>
<DIV> </DIV>
<DIV>ConnectionBendpointTracker is =
independant of the=20
router being used, so it consider *all* operations to be=20
REQ_MOVE_BENDPOINT.  Delete is *interpreted* by the =
BendpointEditPolicy,=20
never sent by the drag tracker. REQ_DELETE_BENDPOINT is never =
used. =20
It should probably be deleted.</DIV>
<BLOCKQUOTE dir=3Dltr=20
style=3D"PADDING-RIGHT: 0px; PADDING-LEFT: 5px; MARGIN-LEFT: 5px; =
BORDER-LEFT: #000000 2px solid; MARGIN-RIGHT: 0px">
<DIV>"Roman Bos=E1k" <<A=20
href=3D"mailto:bosakr@dev.disnet.cz">bosakr@dev.disnet.cz</A>> =
wrote in=20
message <A=20
=
href=3D"news:avugni$crl$1@rogue.oti.com">news:avugni$crl$1@rogue.oti.com<=
/A>...</DIV>
<DIV>I am not sure, but I think there is a =
bug in=20
BendpointEditPolicy =
class.=20
When I create <FONT=20
face=3D"Courier New">BendpointRequest with request =
type set to=20
REQ_DELETE_BENDPOINT than no=20
command returned on <FONT=20
face=3D"Courier New">getCommand(request) =
call. Method <FONT=20
face=3D"Courier =
New">getDeleteBendpointCommand(request:BendpointRequest):Command <=
/STRONG>=20
is not called.</DIV>
<DIV>I think that method <FONT=20
face=3D"Courier =
New">getCommand(request:Request) should=20
contain folowing code (or similar)</DIV>
<DIV><FONT=20
face=3D"Courier New" size=3D2> </DIV>
<DIV><FONT=20
face=3D"Courier New" size=3D2>public=20
Command getCommand(Request request) {    =20
if<FONT=20
face=3D"Courier New" size=3D2> =
(REQ_MOVE_BENDPOINT.equals(request.getType()))=20
{         if (isDeleting) {            &nbs=
p;=20
return=20
getDeleteBendpointCommand((BendpointRequest) =
request);    =20
    }         <FONT=20
face=3D"Courier New" size=3D2>return=20
getMoveBendpointCommand((BendpointRequest)request); <FONT=20
face=3D"Courier New" size=3D2>    =
}    =20
if (REQ_CREATE_BENDPOINT.equals(request.getType()))=20
{         return=20
=
getCreateBendpointCommand((BendpointRequest)request);   &nbs=
p;=20
}     if(request.getType().equals(RequestConstants.REQ_DELETE_=
BENDPOINT))=20
{         =
<FONT=20
face=3D"Courier New" size=3D2>return=20
this.getDeleteBendpointCommand((BendpointRequest)=20
request);     }<FONT=20
face=3D"Courier New">     <FONT=20
face=3D"Courier New">return null; <FONT=20
face=3D"Courier New" size=3D2>}</DIV>
<DIV> </DIV>
<DIV>[Q] Do you thing it is correct to =
leave <FONT=20
face=3D"Courier New">REQ_MOVE_BENDPOINT as =
type of=20
request in call <FONT=20
face=3D"Courier New">getDeleteBendpointCommand =
method=20
when isDeleted is =
true? Isn't=20
it better to do something like:</DIV>
<DIV>
public=20
Command getCommand(Request request) {     =
<FONT=20
face=3D"Courier New" size=3D2>if=20
(REQ_MOVE_BENDPOINT.equals(request.getType())) {     =

    if =
(isDeleting)=20
{             =20
=
request.setType(RequestConstants.REQ_DELETE_BENDPOINT); <=
/FONT><FONT=20
size=3D+0>           &n=
bsp; =20
return=20
getDeleteBendpointCommand((BendpointRequest) =
request);    =20
    <FONT=20
face=3D"Courier New" size=3D2>}         <FONT=20
face=3D"Courier New" size=3D2>return=20
getMoveBendpointCommand((BendpointRequest)request); <FONT=20
face=3D"Courier New" size=3D2>    =
}    =20
if (REQ_CREATE_BENDPOINT.equals(request.getType()))=20
{         return=20
=
getCreateBendpointCommand((BendpointRequest)request);   &nbs=
p;=20
}     if(RequestConstants.REQ_DELETE_BENDPOINT.equals(request.getT ype(=
)))=20
=
{           </FONT=
><FONT=20
face=3D"Courier New" size=3D2><FONT=20
face=3D"Courier New" size=3D2>return=20
this.getDeleteBendpointCommand((BendpointRequest)=20
request);     }<FONT=20
face=3D"Courier New">     <FONT=20
face=3D"Courier New">return null; }</DIV>
<DIV> </DIV>
<DIV>Regards,</DIV>
<DIV>Roman Bosak</DIV>
<DIV> </DIV></BLOCKQUOTE></BODY></HTML >

------=_NextPart_000_008A_01C2C6E2.3636BA20--

Previous Topic:	edit part figures
Next Topic:	AbstractEditPart missing addNodeListener ??

Goto Forum:

-=] Back to Top [=-

Current Time: Thu Mar 13 13:00:29 EDT 2025

.:: Contact :: Home ::.

Breadcrumbs

Sign up to our Newsletter