Eclipse Community Forums: Eclipse Platform » Why the problemd view don't use the AdapterManager

Help

Home

Home » Eclipse Projects » Eclipse Platform » Why the problemd view don't use the AdapterManager

Show: Today's Messages :: Show Polls :: Message Navigator

Why the problemd view don't use the AdapterManager [message #336080]

Wed, 20 May 2009 15:15

Simon Bernard

Messages: 345
Registered: July 2009

Senior Member

The problems views test if the selection is an IAdaptable and try to
adapt this one in different classes able to give the resource associated
to the selection.

But why not use the AdapterManager (Platform.getAdapterManager)?

------------------------------------------------------------ -------
@see in org.eclipse.ui.internal.views.markers.ExtendedMarkersView, line
989 :

if (selection instanceof IStructuredSelection) {
for (Iterator iterator = ((IStructuredSelection) selection)
.iterator(); iterator.hasNext();) {
Object object = iterator.next();
if (object instanceof IAdaptable) {

------------------------------------------------------------ --

Report message to a moderator

Re: Why the problemd view don't use the AdapterManager [message #336082 is a reply to message #336080]

Wed, 20 May 2009 17:05

Prakash G.R.

Messages: 621
Registered: July 2009

Senior Member

Simon Bernard wrote:
> The problems views test if the selection is an IAdaptable and try to
> adapt this one in different classes able to give the resource associated
> to the selection.
>
> But why not use the AdapterManager (Platform.getAdapterManager)?

Interesting! I guess its worth to file a bug.

- Prakash
---
http://blog.eclipse-tips.com

Report message to a moderator

Re: Why the problemd view don't use the AdapterManager [message #336089 is a reply to message #336080]

Wed, 20 May 2009 17:56

Paul Webster

Messages: 6859
Registered: July 2009
Location: Ottawa

Senior Member

As Prakash mentioned, please file a bug at
https://bugs.eclipse.org/bugs/enter_bug.cgi?product=Platform &component=UI

In the workbench, we should try and use
org.eclipse.ui.internal.util.Util.getAdapter(Object, Class) to adapt
objects.

PW

--
Paul Webster
http://wiki.eclipse.org/Platform_Command_Framework
http://wiki.eclipse.org/Command_Core_Expressions
http://wiki.eclipse.org/Menu_Contributions
http://wiki.eclipse.org/Menus_Extension_Mapping
http://help.eclipse.org/ganymede/index.jsp?topic=/org.eclips e.platform.doc.isv/guide/workbench.htm

Paul Webster
http://wiki.eclipse.org/Platform_Command_Framework
http://wiki.eclipse.org/Command_Core_Expressions
http://wiki.eclipse.org/Menu_Contributions

Report message to a moderator

Re: Why the problemd view don't use the AdapterManager [message #336131 is a reply to message #336089]

Mon, 25 May 2009 10:18

Simon Bernard

Messages: 345
Registered: July 2009

Senior Member

it's done : https://bugs.eclipse.org/bugs/show_bug.cgi?id=277646

Paul Webster a écrit :
> As Prakash mentioned, please file a bug at
> https://bugs.eclipse.org/bugs/enter_bug.cgi?product=Platform &component=UI
>
> In the workbench, we should try and use
> org.eclipse.ui.internal.util.Util.getAdapter(Object, Class) to adapt
> objects.
>
> PW
>

Report message to a moderator

Previous Topic:	[CommonNavigator] Adding the New Menu
Next Topic:	Strange behaviour of an open shell (needs a mouse click twice before noticing any event on the shell

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

]

Current Time: Sat Dec 21 16:08:34 GMT 2024

.:: Contact :: Home ::.

Breadcrumbs

Sign up to our Newsletter