Eclipse Community Forums: Eclipse Platform » Ctrl+S different behaviour in Eclipse 3.3 and 3.4

Help

Home

Home » Eclipse Projects » Eclipse Platform » Ctrl+S different behaviour in Eclipse 3.3 and 3.4

Show: Today's Messages :: Show Polls :: Message Navigator

Ctrl+S different behaviour in Eclipse 3.3 and 3.4 [message #330360]

Sat, 26 July 2008 11:46

Mathias Schaeffner

Messages: 5
Registered: July 2009

Junior Member

Hi,

I'm developing a multi page editor, similar to the Eclipse Manifest/PlugIn
editor.
Thus my editor class extends org.eclipse.ui.forms.editor.FormEditor.
And it implements the method doSave(IProgressMonitor progressMonitor).

One of the tabs contains a "source editor", which is a subclass of
org.eclipse.ui.editors.text.TextEditor.
This has got a implementation of doSave(IProgressMonitor progressMonitor)
by default (from org.eclipse.ui.texteditor.AbstractTextEditor).

My intention is, that my doSave(IProgressMonitor progressMonitor) method
is called, whenever the user performs a save action.
Whether by clicking the save icon or pressing Ctrl+S.

It works fine in Eclipse 3.3.
But in 3.4 there is a problem, if the source tab is currently active and a
save action is performed.

Clicking the icon calls my doSave() method, but pressing Crtl+S calls the
doSave() in AbstractTextEditor.

But I want that my doSave() method is called every time.

Why is it working in 3.3 but not in 3.4?
Was there a API change or is it a bug?

It seems like the Key handling is different.
In 3.3 it perform the save action in the top level editor class (
multipage editor ).
But in 3.4 it perform the save action in the text editor, which is part of
the multi page editor.

Report message to a moderator

Re: Ctrl+S different behaviour in Eclipse 3.3 and 3.4 [message #330427 is a reply to message #330360]

Mon, 28 July 2008 16:44

Paul Webster

Messages: 6859
Registered: July 2009
Location: Ottawa

Senior Member

Please open a bug at
https://bugs.eclipse.org/bugs/enter_bug.cgi?product=Platform &component=UI

While it should be calling your doSave(*) method on your MPEP,
TextEditor might be an ISaveableSource. Can you reproduce the problem
with a basic MPEP with an embedded TextEditor?

PW

--
Paul Webster
http://wiki.eclipse.org/Platform_Command_Framework
http://wiki.eclipse.org/Command_Core_Expressions
http://wiki.eclipse.org/Menu_Contributions
http://wiki.eclipse.org/Menus_Extension_Mapping
http://help.eclipse.org/help33/index.jsp?topic=/org.eclipse. platform.doc.isv/guide/workbench.htm

Paul Webster
http://wiki.eclipse.org/Platform_Command_Framework
http://wiki.eclipse.org/Command_Core_Expressions
http://wiki.eclipse.org/Menu_Contributions

Report message to a moderator

Re: Ctrl+S different behaviour in Eclipse 3.3 and 3.4 [message #330505 is a reply to message #330427]

Wed, 30 July 2008 15:24

Mathias Schaeffner

Messages: 5
Registered: July 2009

Junior Member

Here is the bug:
https://bugs.eclipse.org/bugs/show_bug.cgi?id=242582

See the attachment to reproduce it.
It's a basic MPEP with a GUI page and an embedded text editor page.

Paul Webster wrote:

> Please open a bug at
> https://bugs.eclipse.org/bugs/enter_bug.cgi?product=Platform &component=UI

> While it should be calling your doSave(*) method on your MPEP,
> TextEditor might be an ISaveableSource. Can you reproduce the problem
> with a basic MPEP with an embedded TextEditor?

> PW

Report message to a moderator

Previous Topic:	[RSA][Plugin Dev][Modeling] Properties view
Next Topic:	Re: Cut/copy/paste at the widget level

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

]

Current Time: Thu Dec 26 21:18:44 GMT 2024

.:: Contact :: Home ::.

Breadcrumbs

Sign up to our Newsletter