Skip to main content


Eclipse Community Forums
Forum Search:

Search      Help    Register    Login    Home
Home » Eclipse Projects » Eclipse Platform » The CursorLinePainter is not friendly ;)
The CursorLinePainter is not friendly ;) [message #326348] Mon, 17 March 2008 09:21 Go to next message
Eclipse UserFriend
Originally posted by: valere.fedronic.ext.streamezzo.com

Hi,

I am actually implementing a custom LineBackgroundListener, that can
emphasize part of a text (e.g set the background color for scriplets in
jsp,or import statements in java ..).

The problem is that the CursorLinePainter, that is installed on the text
editor by the SourceViewerDecorationSupport, always crush the line
background color with the widget's background color,and therefor
annihilates the work done by any other linebackgroundListener.

The only workaround is to deactivate the cursor line painter.

I think that the CursorLinePainter should allows other contributors to
participate in the source viewer decoration.


Valère.
Deleting directory fails in the 3.4M5 test suite on Windows Vista ia32. [message #326350 is a reply to message #326348] Mon, 17 March 2008 12:51 Go to previous messageGo to next message
Rasmus Tehler is currently offline Rasmus TehlerFriend
Messages: 2
Registered: July 2009
Junior Member
Hi! I have a problem with the Eclipse 34M5 test framework,

Deleting directory fails in the 3.4M5 test suite on Windows Vista ia32.

A Test Framework bug occur in Eclipse 3.4M5 on Windows Vista ia32.
After the UI test suite is done, ANT tries to remove the test-eclipse
work folder, this will fail cause two old java processes are still holding
on to it. The ANT target “setup-zip” will fail and the next plugin-target
will fail cause the test framework will not be installed properly.

The Milestone test was tested and failed with both JRockit and Sun SDK
1.5.0_14.

The workaround for this problem is to remove the test suite from test.xml
and then run it as a separate test: edit test.xml

<!-- antcall target="ui" /-->

This is the error messages from cmd:

genResults:
[copy] Copying 1 file to D:\tests\eclipse-testing_34M5\results\xml
[style] Warning: the task name <style> is deprecated. Use <xslt>
instead.
[style] Transforming into D:\tests\eclipse-testing_34M5\results\html
[style] Processing
D:\tests\eclipse-testing_34M5\results\xml\org.eclipse.ui.
tests_win32.win32.x86.xml to
D:\tests\eclipse-testing_34M5\results\html\org.ecli
pse.ui.tests_win32.win32.x86.html
[style] Loading stylesheet
D:\tests\eclipse-testing_34M5\test-eclipse\eclips
e\plugins\org.eclipse.test\JUNIT.XSL

antui:

junit:

setRuntimeArchive:

init:

setup:

setup-zip:
[delete] Deleting directory D:\tests\eclipse-testing_34M5\test-eclipse

BUILD FAILED
D:\tests\eclipse-testing_34M5\test.xml:296: The following error occurred
while e
xecuting this line:
D:\tests\eclipse-testing_34M5\test.xml:266: The following error occurred
while e
xecuting this line:
D:\tests\eclipse-testing_34M5\test.xml:275: The following error occurred
while e
xecuting this line:
D:\tests\eclipse-testing_34M5\test.xml:37: The following error occurred
while ex
ecuting this line:
D:\tests\eclipse-testing_34M5\test.xml:44: Unable to delete directory
D:\tests\e
clipse-testing_34M5\test-eclipse

Total time: 39 minutes 31 seconds



Should I bug report this?


Regards,
Rasmus Tehler
Re: The CursorLinePainter is not friendly ;) [message #326372 is a reply to message #326348] Tue, 18 March 2008 10:15 Go to previous messageGo to next message
Dani Megert is currently offline Dani MegertFriend
Messages: 3802
Registered: July 2009
Senior Member
valere fedronic wrote:
>
> Hi,
>
> I am actually implementing a custom LineBackgroundListener, that can
> emphasize part of a text (e.g set the background color for scriplets
> in jsp,or import statements in java ..).
>
> The problem is that the CursorLinePainter, that is installed on the
> text editor by the SourceViewerDecorationSupport, always crush the
> line background color with the widget's background color,and therefor
> annihilates the work done by any other linebackgroundListener.
>
> The only workaround is to deactivate the cursor line painter.
>
> I think that the CursorLinePainter should allows other contributors to
> participate in the source viewer decoration.
Feel free to provide such an implementation ;-) We can then open up the
SVDS to allow a custom cursor line painter.

Dani
>
>
> Valère.
>
Re: The CursorLinePainter is not friendly ;) [message #326373 is a reply to message #326372] Tue, 18 March 2008 10:45 Go to previous messageGo to next message
Eclipse UserFriend
Originally posted by: valere.fedronic.ext.streamezzo.com

I'll be happy to contribute to the eclipse project.
How can i do this?

Valère.


Daniel Megert a écrit :
> valere fedronic wrote:
>>
>> Hi,
>>
>> I am actually implementing a custom LineBackgroundListener, that can
>> emphasize part of a text (e.g set the background color for scriplets
>> in jsp,or import statements in java ..).
>>
>> The problem is that the CursorLinePainter, that is installed on the
>> text editor by the SourceViewerDecorationSupport, always crush the
>> line background color with the widget's background color,and therefor
>> annihilates the work done by any other linebackgroundListener.
>>
>> The only workaround is to deactivate the cursor line painter.
>>
>> I think that the CursorLinePainter should allows other contributors to
>> participate in the source viewer decoration.
> Feel free to provide such an implementation ;-) We can then open up the
> SVDS to allow a custom cursor line painter.
>
> Dani
>>
>>
>> Valère.
>>
Re: The CursorLinePainter is not friendly ;) [message #326382 is a reply to message #326373] Tue, 18 March 2008 14:53 Go to previous messageGo to next message
Dani Megert is currently offline Dani MegertFriend
Messages: 3802
Registered: July 2009
Senior Member
valere fedronic wrote:
> I'll be happy to contribute to the eclipse project.
> How can i do this?
You file a bug/feature report using bugzilla
(https://bugs.eclipse.org/bugs/). In this case against Platform Text. In
the bug you state that you would like to work an a fix.

Dani
>
> Valère.
>
>
> Daniel Megert a écrit :
>> valere fedronic wrote:
>>>
>>> Hi,
>>>
>>> I am actually implementing a custom LineBackgroundListener, that can
>>> emphasize part of a text (e.g set the background color for scriplets
>>> in jsp,or import statements in java ..).
>>>
>>> The problem is that the CursorLinePainter, that is installed on the
>>> text editor by the SourceViewerDecorationSupport, always crush the
>>> line background color with the widget's background color,and
>>> therefor annihilates the work done by any other linebackgroundListener.
>>>
>>> The only workaround is to deactivate the cursor line painter.
>>>
>>> I think that the CursorLinePainter should allows other contributors
>>> to participate in the source viewer decoration.
>> Feel free to provide such an implementation ;-) We can then open up
>> the SVDS to allow a custom cursor line painter.
>>
>> Dani
>>>
>>>
>>> Valère.
>>>
Re: The CursorLinePainter is not friendly ;) [message #326434 is a reply to message #326382] Wed, 19 March 2008 16:20 Go to previous messageGo to next message
Eclipse UserFriend
Originally posted by: valere.fedronic.ext.streamezzo.com

It is 'worst' than i thought, i have created a friendly
CursorLinePainter, but my line background contributor work is still ignored.

The problem is that the lineBackground event mechanism doesn't propagate
the line background color, i.e if there are several
LineBackgroundListeners, the styledText ask each listener if he want to
change the line background, and, if not, the line color is reset to null
(instead of keeping the previously set color).

I'll file a bug and propose to work on a fix ;).

Valere.




Daniel Megert a écrit :
> valere fedronic wrote:
>> I'll be happy to contribute to the eclipse project.
>> How can i do this?
> You file a bug/feature report using bugzilla
> (https://bugs.eclipse.org/bugs/). In this case against Platform Text. In
> the bug you state that you would like to work an a fix.
>
> Dani
>>
>> Valère.
>>
>>
>> Daniel Megert a écrit :
>>> valere fedronic wrote:
>>>>
>>>> Hi,
>>>>
>>>> I am actually implementing a custom LineBackgroundListener, that can
>>>> emphasize part of a text (e.g set the background color for scriplets
>>>> in jsp,or import statements in java ..).
>>>>
>>>> The problem is that the CursorLinePainter, that is installed on the
>>>> text editor by the SourceViewerDecorationSupport, always crush the
>>>> line background color with the widget's background color,and
>>>> therefor annihilates the work done by any other linebackgroundListener.
>>>>
>>>> The only workaround is to deactivate the cursor line painter.
>>>>
>>>> I think that the CursorLinePainter should allows other contributors
>>>> to participate in the source viewer decoration.
>>> Feel free to provide such an implementation ;-) We can then open up
>>> the SVDS to allow a custom cursor line painter.
>>>
>>> Dani
>>>>
>>>>
>>>> Valère.
>>>>
Re: The CursorLinePainter is not friendly ;) [message #326436 is a reply to message #326382] Wed, 19 March 2008 16:36 Go to previous messageGo to next message
Eclipse UserFriend
Originally posted by: valere.fedronic.ext.streamezzo.com

https://bugs.eclipse.org/bugs/show_bug.cgi?id=223219

Regards,
Valere.

Daniel Megert a écrit :
> valere fedronic wrote:
>> I'll be happy to contribute to the eclipse project.
>> How can i do this?
> You file a bug/feature report using bugzilla
> (https://bugs.eclipse.org/bugs/). In this case against Platform Text. In
> the bug you state that you would like to work an a fix.
>
> Dani
>>
>> Valère.
>>
>>
>> Daniel Megert a écrit :
>>> valere fedronic wrote:
>>>>
>>>> Hi,
>>>>
>>>> I am actually implementing a custom LineBackgroundListener, that can
>>>> emphasize part of a text (e.g set the background color for scriplets
>>>> in jsp,or import statements in java ..).
>>>>
>>>> The problem is that the CursorLinePainter, that is installed on the
>>>> text editor by the SourceViewerDecorationSupport, always crush the
>>>> line background color with the widget's background color,and
>>>> therefor annihilates the work done by any other linebackgroundListener.
>>>>
>>>> The only workaround is to deactivate the cursor line painter.
>>>>
>>>> I think that the CursorLinePainter should allows other contributors
>>>> to participate in the source viewer decoration.
>>> Feel free to provide such an implementation ;-) We can then open up
>>> the SVDS to allow a custom cursor line painter.
>>>
>>> Dani
>>>>
>>>>
>>>> Valère.
>>>>
Re: The CursorLinePainter is not friendly ;) [message #326459 is a reply to message #326434] Thu, 20 March 2008 08:25 Go to previous messageGo to next message
Dani Megert is currently offline Dani MegertFriend
Messages: 3802
Registered: July 2009
Senior Member
valere fedronic wrote:
> It is 'worst' than i thought, i have created a friendly
> CursorLinePainter, but my line background contributor work is still
> ignored.
>
> The problem is that the lineBackground event mechanism doesn't
> propagate the line background color, i.e if there are several
> LineBackgroundListeners, the styledText ask each listener if he want
> to change the line background, and, if not, the line color is reset to
> null (instead of keeping the previously set color).
Using a LineBackgroundListener is at your own risk and not supported by
the text framework (see ITextViewer.getTextWidget()). Simply drop that
approach and use a org.eclipse.jface.text.ITextPresentationListener.

Dani
>
> I'll file a bug and propose to work on a fix ;).
>
> Valere.
>
>
>
>
> Daniel Megert a écrit :
>> valere fedronic wrote:
>>> I'll be happy to contribute to the eclipse project.
>>> How can i do this?
>> You file a bug/feature report using bugzilla
>> (https://bugs.eclipse.org/bugs/). In this case against Platform Text.
>> In the bug you state that you would like to work an a fix.
>>
>> Dani
>>>
>>> Valère.
>>>
>>>
>>> Daniel Megert a écrit :
>>>> valere fedronic wrote:
>>>>>
>>>>> Hi,
>>>>>
>>>>> I am actually implementing a custom LineBackgroundListener, that
>>>>> can emphasize part of a text (e.g set the background color for
>>>>> scriplets in jsp,or import statements in java ..).
>>>>>
>>>>> The problem is that the CursorLinePainter, that is installed on
>>>>> the text editor by the SourceViewerDecorationSupport, always crush
>>>>> the line background color with the widget's background color,and
>>>>> therefor annihilates the work done by any other
>>>>> linebackgroundListener.
>>>>>
>>>>> The only workaround is to deactivate the cursor line painter.
>>>>>
>>>>> I think that the CursorLinePainter should allows other
>>>>> contributors to participate in the source viewer decoration.
>>>> Feel free to provide such an implementation ;-) We can then open up
>>>> the SVDS to allow a custom cursor line painter.
>>>>
>>>> Dani
>>>>>
>>>>>
>>>>> Valère.
>>>>>
Re: The CursorLinePainter is not friendly ;) [message #326469 is a reply to message #326459] Thu, 20 March 2008 10:46 Go to previous message
Eclipse UserFriend
Originally posted by: valere.fedronic.ext.streamezzo.com

Thanks for the tip daniel,
But i really need to use a lineBackgroundListener.

Valère.
Previous Topic:How to create an editor?
Next Topic:creating an IFile from an InputStream
Goto Forum:
  


Current Time: Sat Oct 19 06:26:06 GMT 2024

Powered by FUDForum. Page generated in 0.04369 seconds
.:: Contact :: Home ::.

Powered by: FUDforum 3.0.2.
Copyright ©2001-2010 FUDforum Bulletin Board Software

Back to the top