| (no subject) [message #685498] |
Fri, 17 June 2011 12:15  |
Eclipse User |
|
|
|
I was looking at ScriptElementImageDescriptor today, and I found this
code in the equals() method:
return (other.fFlags == this.fFlags) &&
(fBaseImage.equals(other.fBaseImage) == fSize.equals(other.fSize));
Is that a bug? Because if the fBaseImage is not equal, and the fSize is
not equal as well, then the equals result will be true. That doesn't
seem right.
- Bruno Medeiros
D Development Tools: http://code.google.com/a/eclipselabs.org/p/ddt/
|
|
|
| Re: Bug in ScriptElementImageDescriptor ? [message #883026 is a reply to message #685498] |
Thu, 07 June 2012 13:04  |
| Eclipse User |
|
|
|
Hi Bruno,
This bug was fixed.
Thanks,
Alex
On 06/17/2011 11:15 PM, Bruno Medeiros wrote:
> I was looking at ScriptElementImageDescriptor today, and I found this
> code in the equals() method:
>
> return (other.fFlags == this.fFlags) &&
> (fBaseImage.equals(other.fBaseImage) == fSize.equals(other.fSize));
>
> Is that a bug? Because if the fBaseImage is not equal, and the fSize is
> not equal as well, then the equals result will be true. That doesn't
> seem right.
>
> - Bruno Medeiros
> D Development Tools: http://code.google.com/a/eclipselabs.org/p/ddt/
|
|
|
Powered by
FUDForum. Page generated in 0.03988 seconds
Home