Eclipse Community Forums: EMF » Why refresh call in PlatformResourceURIHandlerImpl.WorkbenchHelper.createPlatformResourceInputStream

Home » Modeling » EMF » Why refresh call in PlatformResourceURIHandlerImpl.WorkbenchHelper.createPlatformResourceInputStream

Show: Today's Messages :: Show Polls :: Message Navigator

Why refresh call in PlatformResourceURIHandlerImpl.WorkbenchHelper.createPlatformResourceInputStream [message #1852504]

Thu, 19 May 2022 07:33

Christian Dietrich

Messages: 14673
Registered: July 2009

Senior Member

why is there a refresh call for out of sync files in PlatformResourceURIHandlerImpl.WorkbenchHelper.createPlatformResourceInputStream
if the read is done outside of a workspace/resource lock holding thread this might lead to a wait for the workspace lock to be resolved.

Twitter : @chrdietrich
Blog : https://www.dietrich-it.de

Report message to a moderator

Re: Why refresh call in PlatformResourceURIHandlerImpl.WorkbenchHelper.createPlatformResourceInputSt [message #1852507 is a reply to message #1852504]

Thu, 19 May 2022 10:51

Ed Merks

Messages: 33143
Registered: July 2009

Senior Member

Because the subsequent call to org.eclipse.core.resources.IFile.setContents(InputStream, boolean, boolean, IProgressMonitor) throws CoreException if "The workspace is not in sync with the corresponding location in the local file system and <code>force </code> is <code>false</code where org.eclipse.emf.ecore.resource.impl.PlatformResourceURIHandlerImpl.WorkbenchHelper.createPlatformResourceOutputStream(String, Map<?, ?>) generally calls it with false.

Ed Merks
Professional Support: https://www.macromodeling.com/

Report message to a moderator

Re: Why refresh call in PlatformResourceURIHandlerImpl.WorkbenchHelper.createPlatformResourceInputSt [message #1852508 is a reply to message #1852507]

Thu, 19 May 2022 11:58

Christian Dietrich

Messages: 14673
Registered: July 2009

Senior Member

for output stream it is clear, i am asking on inputstream

Twitter : @chrdietrich
Blog : https://www.dietrich-it.de

Report message to a moderator

Re: Why refresh call in PlatformResourceURIHandlerImpl.WorkbenchHelper.createPlatformResourceInputSt [message #1852513 is a reply to message #1852508]

Thu, 19 May 2022 12:56

Ed Merks

Messages: 33143
Registered: July 2009

Senior Member

IFile.getContents() throws

	
	 * <li> {@link IResourceStatus#OUT_OF_SYNC_LOCAL} - The workspace is not in sync with
	 * 		 the corresponding location in the local file system (and
	 *       {@link ResourcesPlugin#PREF_LIGHTWEIGHT_AUTO_REFRESH} is disabled).</li>

And note that PREF_LIGHTWEIGHT_AUTO_REFRESH is @since 3.7 and this plugin has "org.eclipse.core.resources;bundle-version="[3.6.0,4.0.0)". We could still test the preference using the "refresh.lightweight.enabled" string to avoid the refresh call if that's helpful. But are you sure that's actually helpful or would it just move the problem to happen during the getContents call?

Ed Merks
Professional Support: https://www.macromodeling.com/

Report message to a moderator